Skip to content

Use sponge-cursor to remove unnecessary buffering#849

Merged
newpavlov merged 12 commits into
masterfrom
sponge-cursor
May 8, 2026
Merged

Use sponge-cursor to remove unnecessary buffering#849
newpavlov merged 12 commits into
masterfrom
sponge-cursor

Conversation

@newpavlov
Copy link
Copy Markdown
Member

@newpavlov newpavlov commented May 2, 2026 •
edited
Loading

Removes unnecessary buffering from sponge-based constructions using the sponge-cursor crate (see RustCrypto/utils#1477).

@newpavlov newpavlov changed the title Use sponge-cursor Use sponge-cursor to remove unnecessary buffering May 2, 2026
@newpavlov newpavlov mentioned this pull request May 3, 2026
Merged
@newpavlov newpavlov mentioned this pull request May 4, 2026
Merged
@newpavlov
Copy link
Copy Markdown
Member Author

newpavlov commented May 6, 2026

@tarcieri
I think we can migrate sha3 as well, but it would involve breaking changes (removal of block_api and change of the serialization format), so it would have to be done in a new breaking release. What do you think, should we migrate it or leave as-is?

@tarcieri
Copy link
Copy Markdown
Member

tarcieri commented May 6, 2026

I think it’s fine to migrate though at this point I think you’d have to bump minor version, which I’m ok with

@newpavlov newpavlov merged commit 12105d3 into master May 8, 2026
269 checks passed
@newpavlov newpavlov deleted the sponge-cursor branch May 8, 2026 19:36
makavity pushed a commit to makavity/hashes that referenced this pull request May 8, 2026
@newpavlov @makavity
Use sponge-cursor to remove unnecessary buffering (RustCrypto#849)
6e8b41c 
Removes unnecessary buffering from sponge-based constructions using the
`sponge-cursor` crate (see RustCrypto/utils#1477).
@newpavlov newpavlov mentioned this pull request May 12, 2026
Merged
newpavlov added a commit that referenced this pull request May 12, 2026
@newpavlov
Release ascon-xof128 v0.2.0 (#860)
4e11f39 
### Changed
- Internal implementation by removing unnecessary buffering ([#849])
- Serialization format used by `SerializableState` implementations
([#849])
- Replaced implementation of `CustomizedInit` with `TryCustomizedInit`
([#857])

[#849]: #849
[#857]: #857
@newpavlov newpavlov mentioned this pull request May 12, 2026
Merged
newpavlov added a commit that referenced this pull request May 12, 2026
@newpavlov
Release cshake v0.2.0 (#864)
7078f0c 
### Added
- `CShake128Reader` and `CShake256Reader` type aliases ([#855])

### Changed
- Internal implementation by removing unnecessary buffering ([#849])
- `Rate: BlockSizes` generic parameter to `const RATE: usize` ([#849])

### Removed
- Implementations of `BlockSizeUser` ([#856])

[#849]: #849
[#855]: #855
[#856]: #856
@newpavlov newpavlov mentioned this pull request May 12, 2026
Merged
newpavlov added a commit that referenced this pull request May 12, 2026
@newpavlov
Release k12 v0.5.0 (#865)
25a14b0 
### Changed
- Internal implementation by removing unnecessary buffering ([#849])
- `Rate: BlockSizes` generic parameter to `const RATE: usize` ([#849])

### Removed
- Implementations of `BlockSizeUser` ([#856])

[#849]: #849
[#856]: #856
@newpavlov newpavlov mentioned this pull request May 13, 2026
Merged
newpavlov added a commit that referenced this pull request May 13, 2026
@newpavlov
Release turboshake v0.7.0 (#868)
6b89f1f 
### Added
- `CTurboShake128` and `CTurboShake256` type aliases generic over domain
separator ([#866])

### Changed
- Internal implementation by removing unnecessary buffering ([#849])
- `Rate: BlockSizes` generic parameter to `const RATE: usize` ([#849])
- `TurboShake128` and `TurboShake256` type aliases are no longer generic
over the domain separator
  and use the default value instead ([#866])

### Removed
- Implementations of `BlockSizeUser` ([#856])

[#849]: #849
[#856]: #856
[#866]: #866
@newpavlov newpavlov mentioned this pull request May 15, 2026
Merged
newpavlov added a commit that referenced this pull request May 15, 2026
@newpavlov
Release sha3 v0.12.0 (#875)
0bdea4f 
### Changed
- Internal implementation by removing unnecessary buffering ([#849])
- Serialization format used by `SerializableState` trait implementations
([#849])

### Removed
- `Shake`, `Shake128`, and `Shake256` types (moved to the `shake` crate)
([#869])

[#849]: #849
[#869]: #869
@RoDmitry
Copy link
Copy Markdown

RoDmitry commented May 17, 2026 •
edited
Loading

How do I use sha3 with hmac after the removal of block_api then? Am I missing something?

@newpavlov
Copy link
Copy Markdown
Member Author

newpavlov commented May 17, 2026

You can use SimpleHmac.

@baloo
Copy link
Copy Markdown
Member

baloo commented May 20, 2026 •
edited
Loading

This also affects the use of EagerHash in ecdsa:
https://docs.rs/ecdsa/0.17.0-rc.18/ecdsa/struct.SigningKey.html#method.sign_digest_recoverable

That can't be used anymore with sha3 anymore. This show up in https://github.com/RustCrypto/elliptic-curves/blob/a64c16cc3909d4489a2b0300886aa9f0a1691ba6/k256/src/ecdsa.rs#L243

EDIT:
that requirements comes from RustCrypto/signatures#1076 but I'm sure on this line it actually applies.

EDIT2:
this also limits the use of dsa::SigningKey::sign_prehash_rfc6979: https://github.com/RustCrypto/signatures/blob/699547f9c3593578f6d28f4e73a282ba526c8626/dsa/src/signing_key.rs#L95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@newpavlov @tarcieri @RoDmitry @baloo